Skip to content

Change color of accepted lines from blue to orange - #1895

Merged
schluis merged 2 commits into
HULKs:mainfrom
schluis:line-detection-twix-color
Jul 7, 2025
Merged

Change color of accepted lines from blue to orange #1895
schluis merged 2 commits into
HULKs:mainfrom
schluis:line-detection-twix-color

Conversation

@schluis

@schluis schluis commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Why? What?

  • for better visibility

How to Test

  • Look at lines in twix with all other overlays enabled

visibility

Co-authored-by: Franziska-Sophie <74772344+Franziska-Sophie@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to Request for Review in Development Jun 25, 2025
@schluis schluis added tools:Debug Tooling Related to twix et.al. is:Easy labels Jun 25, 2025
@schluis
schluis enabled auto-merge June 25, 2025 12:20
@schluis schluis changed the title Change color of accepted lines from green to orange Change color of accepted lines from blue to orange Jun 25, 2025
@schluis

schluis commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

Rasmus findet es gut, ist aber auch nicht farbenblind

@schmidma

Copy link
Copy Markdown
Member

Ich finde es nicht gut, weil wir bereits gelbe Linien haben

@schluis

schluis commented Jun 26, 2025

Copy link
Copy Markdown
Contributor Author

Hast du es dir angeschaut? Visuell war es gestern gut zu unterscheiden. Hast du einen Vorschlag für eine andere Farbe? Vielelicht ein dunkleres Orange?

@oleflb

oleflb commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

@schluis This tool may help you: https://www.color-blindness.com/coblis-color-blindness-simulator/
You can upload images there and select different levels of color blindness.
I also found this short article: https://davidmathlogic.com/colorblind/#%23D81B60-%231E88E5-%23FFC107-%23004D40
which features some accessible palettes

@schmidma

schmidma commented Jul 7, 2025

Copy link
Copy Markdown
Member

orange ist okay

@schluis

schluis commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

Okay dann mergen wir so!!!

@schluis
schluis added this pull request to the merge queue Jul 7, 2025
Merged via the queue into HULKs:main with commit 6eb8102 Jul 7, 2025
27 checks passed
@schluis
schluis deleted the line-detection-twix-color branch July 7, 2025 19:27
@github-project-automation github-project-automation Bot moved this from Request for Review to Done in Development Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:Easy tools:Debug Tooling Related to twix et.al.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants